Look up the class discriminator value by its name in the PolymorphismDecoder#28
Open
jenssuhr wants to merge 1 commit intojershell:masterfrom
Open
Look up the class discriminator value by its name in the PolymorphismDecoder#28jenssuhr wants to merge 1 commit intojershell:masterfrom
jenssuhr wants to merge 1 commit intojershell:masterfrom
Conversation
…Decoder This allows correct deserialization of BSON documents where the discriminator is not one of the first two elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current state
The PolymorphismDecoder expects the first field in the BSON document (or the second, if the first one is the
_id) to contain the class discriminator. If the discriminator field is at another position in the document, deserialization fails.Example:
Parsing the following document
{ "payload": { "_id": { "$oid": "5d1777814e8c7b408a6ada73" }, "someData": "something", "___type": "com.github.jershell.kbson.models.polymorph.SMessage.DataWithObjectId" } }leads to
Proposed solution
With this pull request,
decodeElementIndexactively looks for a field with the configured class discriminator's name. It also allows removing thealreadyReadIdparameters introduced in #19.This change adds a few more read calls, but I think the tradeoff is worth it for a bit more robustness.