Skip to content

Copy offline dependencies instead of moving #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jericop wants to merge 1 commit into from
Closed

Copy offline dependencies instead of moving #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions commands/pack.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package commands

import (
"fmt"
"io"
"os"
"path/filepath"
"runtime"
Expand Down Expand Up @@ -191,9 +192,9 @@ func packRun(flags packFlags) error {
return fmt.Errorf("failed to create platform specific dependencies directory: %s", err)
}

err = os.Rename(filepath.Join(tmpDir, offlinePath), filepath.Join(tmpDir, targetPlatformDir, dependenciesDir, offlineFilename))
_, err = copyFile(filepath.Join(tmpDir, offlinePath), filepath.Join(tmpDir, targetPlatformDir, dependenciesDir, offlineFilename))
if err != nil {
return fmt.Errorf("failed to move offline dependency to platform specific directory: %s", err)
return fmt.Errorf("failed to copy offline dependency to platform specific directory: %s", err)
}

config.Metadata.IncludeFiles = append(config.Metadata.IncludeFiles, filepath.Join(targetPlatformDir, dependenciesDir, offlineFilename))
Expand Down Expand Up @@ -302,3 +303,36 @@ func archFromSystem() string {

return runtime.GOARCH
}

func copyFile(src string, dst string) (int64, error) {
sourceFileStat, err := os.Stat(src)
if err != nil {
return 0, err
}
if !sourceFileStat.Mode().IsRegular() {
return 0, fmt.Errorf("%s is not a regular file", src)
}

source, err := os.Open(src)
if err != nil {
return 0, err
}
defer func() {
if err2 := source.Close(); err2 != nil && err == nil {
err = err2
}
}()

destination, err := os.Create(dst)
if err != nil {
return 0, err
}
defer func() {
if err2 := destination.Close(); err2 != nil && err == nil {
err = err2
}
}()

nBytes, err := io.Copy(destination, source)
return nBytes, err
}
Loading