Add support for linking to Trac instances using multiple repositories#6
Open
ghost wants to merge 1 commit intojenkinsci:masterfrom
Open
Add support for linking to Trac instances using multiple repositories#6ghost wants to merge 1 commit intojenkinsci:masterfrom
ghost wants to merge 1 commit intojenkinsci:masterfrom
Conversation
Member
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
This looks like a helpful enhancement to match the trac multiple repositories facility. I will try and get this updated code working on my Trac instance (which has 3 repos in it) and then feed back here. I can start following the suggested actions in the Link provided by Jenkins too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using multiple repositories in a single Trac instance, the name of the repository must be included in the link. The AppendedToBrowser property wasn't sufficient, as the repository name appears in different parts of the link, depending on its context ("changeset:" vs. "browser:" links).
This change modifies the TracProjectProperty class constructor to take another argument (the Trac repository name). It also adds wraps the config.jelly elements in a "section" element, which seems to fix the "advanced" section not showing up (Jenkins 1.609.1) on the configuration page.