Remove explicit JUnit 4 dependency declaration#1353
Open
strangelookingnerd wants to merge 1 commit intojenkinsci:masterfrom
Open
Remove explicit JUnit 4 dependency declaration#1353strangelookingnerd wants to merge 1 commit intojenkinsci:masterfrom
strangelookingnerd wants to merge 1 commit intojenkinsci:masterfrom
Conversation
| <rules> | ||
| <RestrictImports> | ||
| <reason>Use JUnit 5 (org.junit.jupiter.*)</reason> | ||
| <reason>Use JUnit Jupiter (org.junit.jupiter.*)</reason> |
Contributor
Author
There was a problem hiding this comment.
Updated the naming to be more consistent, since we are using JUnit 6.x by now.
6 tasks
Member
Or What you are removing here is not an explicit dependency declaration as claimed; it is the It is not clear to me what the actual purpose of this change is. -0 for now |
jonesbusy
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the explicit JUnit 4 dependency declaration.
It is still transitively pulled through
junit-vintage-engineso there is no reason to declare it again.This change could be considered
breakingas consumers that have a hard dependency onjunit:junitwould likely fail to build (e.g. jenkinsci/xshell-plugin#260). Otherwise there should be no side-effects, meaning plugins that still use JUnit 4 (but don't declare it) are not affected.I want to take this measure to push the JUnit Jupiter migration as discussed on the Contributor Summit 2026.
Testing done
Tested locally.
Submitter checklist