Open
Conversation
Author
|
Hello @olivergondza |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #340
Problem resolution :
□ Log level: warning
□ Message: "Login failure: " + details
Testing :
Test 1 :
Two clouds are configured and both are available
Two jobs
Expected result: Both jobs are built
Test 2 :
First Cloud down - simulate outage by providing invalid credentials
Two jobs
Expected result: Both jobs should be built using the remaining cloud
Test 3 :
Second Cloud down - simulate outage by providing invalid credentials
Two jobs
Expected result: Both jobs should be built using the remaining cloud
□ Made The LoginFailure exception (From JCloudsCloud.java) public so it can be used during the tests
□ Added (overloaded ) a MockJCloudsCloud constructor to provide clouds with null credentials for the tests