Skip to content

[JENKINS-74120] Remove inline js script in ScriptConfig/edit-config.jelly #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shlomomdahan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[JENKINS-74120] Remove inline js script in ScriptConfig/edit-config.jelly #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c85a33e
remove inline js script in ScriptConfig/edit-config.jelly
shlomomdahan Dec 6, 2024
11ea3ee
remove inline js script in ScriptConfig/edit-config.jelly
shlomomdahan Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions ...ain/resources/org/jenkinsci/plugins/managedscripts/ScriptConfig/edit-config-codemirror.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
document.onreadystatechange = function(){
// editor.on seems to require newer codemirror version
// var pending;
// editor.on("change", function() {
// clearTimeout(pending);
// pending = setTimeout(update, 400);
// });
function looksLike(code) {
var firstline = code.split('\n')[0];
if(firstline.indexOf('#!') == 0){
var shellpattern = /bin\/[\w]{0,2}sh/;
var shellpatternwin = /[\w]{0,2}sh\.exe/;
if(firstline.indexOf('python') > -1){
return "python";
// perl requires stapler-adjunct-codemirror > 1.3
}else if(firstline.indexOf('perl') > -1){
return "perl";
}else if(shellpattern.exec(firstline) || shellpatternwin.exec(firstline)){
return "shell";
}
}
}
function update() {
editor.setOption("mode", looksLike(editor.getValue()));
}
update();
};
30 changes: 1 addition & 29 deletions src/main/resources/org/jenkinsci/plugins/managedscripts/ScriptConfig/edit-config.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,34 +55,6 @@ THE SOFTWARE.
org.kohsuke.stapler.codemirror.mode.shell.shell,
org.kohsuke.stapler.codemirror.mode.perl.perl,
"/>
<script>
document.onreadystatechange = function(){
// editor.on seems to require newer codemirror version
// var pending;
// editor.on("change", function() {
// clearTimeout(pending);
// pending = setTimeout(update, 400);
// });
function looksLike(code) {
var firstline = code.split('\n')[0];
if(firstline.indexOf('#!') == 0){
var shellpattern = /bin\/[\w]{0,2}sh/;
var shellpatternwin = /[\w]{0,2}sh\.exe/;
if(firstline.indexOf('python') > -1){
return "python";
// perl requires stapler-adjunct-codemirror > 1.3
}else if(firstline.indexOf('perl') > -1){
return "perl";
}else if(shellpattern.exec(firstline) || shellpatternwin.exec(firstline)){
return "shell";
}
}
}
function update() {
editor.setOption("mode", looksLike(editor.getValue()));
}
update();
};
</script>
<st:adjunct includes="org.jenkinsci.plugins.managedscripts.ScriptConfig.edit-config-codemirror"/>
</f:entry>
</j:jelly>