Skip to content

[JENKINS-74118] Remove inline onClick handlers in ScriptBuildStep/config.jelly #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shlomomdahan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[JENKINS-74118] Remove inline onClick handlers in ScriptBuildStep/config.jelly #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/resources/org/jenkinsci/plugins/managedscripts/ScriptBuildStep/config.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
<f:select />
</f:entry>

<a target="_blank" style="display:none;" href="" onclick="window.open(this.href,'window','width=900,height=640,resizable,scrollbars,toolbar,menubar') ;return false;">view selected script</a>
<st:adjunct includes="org.jenkinsci.plugins.managedscripts.ScriptBuildStep.script-build-step"/>
<a target="_blank" style="display:none;" href="" class="script-build-window-link">view selected script</a>

<f:optionalBlock name="defineArgs" inline="true" title="${%Define arguments}" checked="${!empty(instance.buildStepArgs)}" help="/plugin/managed-scripts/help-defineArgs.html">
<f:entry field="tokenized">
Expand All @@ -16,7 +17,7 @@
<div name="argName"><st:nbsp/></div>
<input type="text" name="arg" value="${arg}" size="80"/>
<input type="button" name="delete_button" value="${%Delete}" class="repeatable-delete show-if-not-only" style="margin-left: 1em;" />
<input type="button" name="add_button" onClick="ms_labelArgs()" value="${%Add argument}" class="repeatable-add show-if-last" />
<input type="button" name="add_button" value="${%Add argument}" class="repeatable-add show-if-last" />
</f:entry>
</f:repeatable>
</f:optionalBlock>
Expand Down
8 changes: 8 additions & 0 deletions src/main/resources/org/jenkinsci/plugins/managedscripts/ScriptBuildStep/script-build-step.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
document.addEventListener("DOMContentLoaded", function () {
const scriptLink = document.querySelector(".script-build-window-link");

scriptLink.addEventListener("click", function (e) {
e.preventDefault();
window.open(e.href, "window", "width=900,height=640,resizable,scrollbars,toolbar,menubar");
});
});