Skip to content

tests: fix test coverage/results test typos #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
puskunalis wants to merge 2 commits into
base: master
Choose a base branch
from
Open

tests: fix test coverage/results test typos #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cda088
tests: fix test coverage/results test typos
puskunalis Dec 20, 2024
acb4b3b
fix jackson-databind version
puskunalis Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>[2.9.10,)</version>
<version>2.9.9.1</version>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/jenkinsci/plugins/githubautostatus/BuildStatusConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ public void testDoFillCredentialsIdItemsAddsFromCredentialsStore() throws IOExce
public void testIgnoreSendingTestCoverageToInfluxDbFalse() {
BuildStatusConfig instance = new BuildStatusConfig();
boolean expectedIgnoreSendingTestCoverageToInflux = false;
instance.setIgnoreSendingTestResultsToInflux(expectedIgnoreSendingTestCoverageToInflux);
instance.setIgnoreSendingTestCoverageToInflux(expectedIgnoreSendingTestCoverageToInflux);
boolean result = instance.getIgnoreSendingTestCoverageToInflux();
assertEquals(expectedIgnoreSendingTestCoverageToInflux, result);
}
Expand All @@ -290,7 +290,7 @@ public void testIgnoreSendingTestCoverageToInfluxDbTrue() {
public void testIgnoreSendingTestResultsToInfluxDbTrue() {
BuildStatusConfig instance = new BuildStatusConfig();
boolean expectedIgnoreSendingTestResultsToInflux = true;
instance.setIgnoreSendingTestCoverageToInflux(expectedIgnoreSendingTestResultsToInflux);
instance.setIgnoreSendingTestResultsToInflux(expectedIgnoreSendingTestResultsToInflux);
boolean result = instance.getIgnoreSendingTestResultsToInflux();
assertEquals(expectedIgnoreSendingTestResultsToInflux, result);
}
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/jenkinsci/plugins/githubautostatus/config/InfluxDbNotifierConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public void testGetCredentialsEmpty() {
public void testGetIgnoreSendingTestCoverageToInflux() {
InfluxDbNotifierConfig instance
= InfluxDbNotifierConfig.fromGlobalConfig("", "", branch);
assertEquals(ignoreSendingTestResultsToInflux, instance.getIgnoreSendingTestCoverageToInflux());
assertEquals(ignoreSendingTestCoverageToInflux, instance.getIgnoreSendingTestCoverageToInflux());
}

@Test
Expand Down