Add Makefile and update Dev Container and documentation #115
Merged
shenxianpeng merged 6 commits intomainfrom Mar 17, 2026
Merged
Add Makefile and update Dev Container and documentation #115shenxianpeng merged 6 commits intomainfrom
shenxianpeng merged 6 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to provide a more “out of the box” local development experience by adding a Makefile, updating contributor documentation accordingly, and enhancing the devcontainer setup.
Changes:
- Added a
Makefilewith common Maven build/test/run/lint targets. - Updated
CONTRIBUTING.mdand.github/copilot-instructions.mdto document the newmakeworkflow. - Updated
.devcontainer/devcontainer.json(adds Node feature and a newpostCreateCommand).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
Makefile |
Introduces make targets for compile/test/verify/package/run/debug/lint and reinstall. |
CONTRIBUTING.md |
Documents the new Makefile-based dev workflow and lint command. |
.github/copilot-instructions.md |
Adds a Makefile target mapping table for contributors and automation guidance. |
.devcontainer/devcontainer.json |
Adds Node feature and runs additional setup commands on container creation. |
.agents/skills/review-pull-request/SKILL.md |
Adds internal documentation for a PR review workflow. |
You can also share your feedback on Copilot code review. Take the survey.
.github/copilot-instructions.md
Outdated
| | `make verify` | `mvn verify` | Full CI check | | ||
| | `make package` | `mvn package -DskipTests` | Build .hpi file | | ||
| | `make run` | `mvn hpi:run` | Start Jenkins with plugin | | ||
| | `make debug` | `mvnDebug hpi:run` | Start Jenkins with remote debugger | |
Makefile
Outdated
Comment on lines
+36
to
+37
| reinstall: clean package ## Clean, rebuild, and install .hpi locally | ||
| mvn install -DskipTests |
shenxianpeng
force-pushed
the
feature/update-dev-container
branch
from
0b984a9 to
dc21546
Compare
shenxianpeng
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Dev container to have a out of box environment for development.
And add Makefile to simplified build and testing commands.
Testing done
New added make commands need to be tested.
Submitter checklist