[JENKINS-64751] Quote "docker exec" env-vars on Windows#245
Merged
rsandell merged 1 commit intojenkinsci:masterfrom Jan 27, 2022
TBBle:quote-docker_exec-env_vars-on-windows
Merged
[JENKINS-64751] Quote "docker exec" env-vars on Windows#245rsandell merged 1 commit intojenkinsci:masterfrom TBBle:quote-docker_exec-env_vars-on-windows
rsandell merged 1 commit intojenkinsci:masterfrom
TBBle:quote-docker_exec-env_vars-on-windows
Conversation
Contributor
Author
Contributor
Author
|
Hmm. Both this and #244 hit an hour timeout in the CI system, and nothing's been built since six days ago, or merged into mainline since December, when it wasn't having that issue. So I suspect something's borked on the CI infrastructure side. |
Contributor
Author
Contributor
Author
|
Local test using |
6 tasks
rsandell
approved these changes
Jan 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on c97bf23 from #220 which quoted "docker run" env-vars, this addresses JENKINS-64751 and JENKINS-65933.
I have not included any tests, as my understanding from #215 is that we do not have test infrastructure that supports docker-execution tests on Windows, similarly to #220.