Updated to use Jenkins API, handles deletion using thresholds.#3
Updated to use Jenkins API, handles deletion using thresholds.#3franostanisicserato wants to merge 13 commits into
Conversation
…g jenkins API and thersholds.
…g jenkins API and thresholds.
There was a problem hiding this comment.
This block is used for maintainers, IIUC you're not a maintainer on this plugin. If you want your name be added, use <contributors> instead.
|
As you requested review: thanks for the work! I'm not the maintainer of that plugin, but here's my 2 cents:
Hope this helps |
There was a problem hiding this comment.
Better to stick to Jenkins LTS
|
The code is barely reviewable due to the formatting changes. Since the original code is not excellent, it's hard to discover issues in the new code |
There was a problem hiding this comment.
Using SimpleBuildWrapper instead of BuildWrapper (by following this instructions) would make this plugin plugin more actual (by using newer Jenkins APIs) and compatible with Workflow (which is make usable as a Workflow step).
There was a problem hiding this comment.
Note that this is only a suggestion, not required at all, of course.
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
This was happening when a slave was connecting and did not have any disk information, then the plugin was doing a system.exit()...
Removed unused and empty parameters.
Followed bug/warning from the build to remove the warnings.
Jelly now needs this line for security reasons.
As it's the output build.
It was failing with weird errors otherwise, also it was quite outdated.
We don't want to have the same version as the original plugin to avoid updating our one with the official one (as shown in Jenkins plugin manager) so we make sure it's higher. We will eventually use our own version/id to diverge from the original one.
5 participants
Consolidated other pull requests, cleaned up some of the code and added a new method for deletion whereby the user specifies an upper bound to trigger the check (as prior), but instead of how it was prior (deleting all workspaces) the plugin now deletes workspaces sequentially, starting with the oldest, until a lower threshold is hit (also specified by the user). The user can also set this to 0 to delete all workspaces as the original functionality did.