Add documentation comment for IS_FORK workflow bug fix #1896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow run #20105424925 skipped all Docker image builds despite Dockerfile changes. The weekly branch had a buggy IS_FORK check that evaluated to
truefor push events.Analysis
The old implementation accessed
github.event.pull_request.head.repo.full_namewithout checking event type:For push events,
github.event.pull_request.head.repo.full_nameis null, so'' != 'jenkins-docs/quickstart-tutorials'→IS_FORK=true→ build steps skipped.The Fix
Added documentation comment to the workflow file (lines 25-26) explaining how the fix prevents IS_FORK from being incorrectly set to true for push events:
The workflow now checks
github.event_namebefore accessing pull_request fields, ensuring IS_FORK is correctly set to false for push events.Validation
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.