Extendable routes, mockApi and clientOptions in storage#88
Open
Vishtar wants to merge 4 commits intojehy:masterfrom
Open
Extendable routes, mockApi and clientOptions in storage#88Vishtar wants to merge 4 commits intojehy:masterfrom
Vishtar wants to merge 4 commits intojehy:masterfrom
Conversation
Owner
|
Hi! Looks really good. Can you add information about those features to readme? |
Author
Ofc! Added almost the same text to the bottom of the readme. |
Owner
|
Great! Gonna take a closer look today and merge. |
1 similar comment
FezVrasta
reviewed
Jul 29, 2024
|
|
||
| ```typescript | ||
| export const getChat: TExpressRoute = (app, telegramServer) => { | ||
| handle(app, '/bot:token/getChat', (req, res, _next) => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need more APIs than this library has, but there is no easy way to add new routes and store mock data for new APIs.
Mock data can be stored in an extended class, etc. But the native way seems better.
Example of expandable routes:
And custom route:
I also apretiate the ability to store exist client options to use it in mocks:
What do you think?