Added setting of ActivationFunction into cloned FeedforwardLayer during FeedforwardNetwork#cloneStructure()#2
Open
its-sunny-day wants to merge 1 commit intojeffheaton:masterfrom
Open
Conversation
…ng FeedforwardNetwork#cloneStructure(). Without this changes information about activation functions will be lost during FeedforwardNetwork#clone() (and layers of cloned network will always have ActivationSigmoid function).
|
|
||
| for (final FeedforwardLayer layer : this.layers) { | ||
| final FeedforwardLayer clonedLayer = new FeedforwardLayer(layer | ||
| final FeedforwardLayer clonedLayer = new FeedforwardLayer(layer.getActivationFunction(), layer |
There was a problem hiding this comment.
layer.cloneStructure() would suffice
Owner
|
Thanks! That makes sense, I will take a further look and merge soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this changes information about activation functions will be lost during FeedforwardNetwork#clone()
(and layers of cloned network will always have ActivationSigmoid function).