Add support for custom HTTP(S) agents#107
Open
deg0nz wants to merge 4 commits intojeffbski:masterfrom
Open
Conversation
…z/wait-on into support-custom-http$-agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I had the need to use
wait-onfor HTTP requests via a SOCKS proxy, so I added the functionality to hand over custom Agents to Axios. The agents are optional in Axios configs, so the handover ofundefinedshould be fine.If you would like something changed, please tell me. I'm not so familiar with some of the JS syntax you use here, so please bare with me if I missed something.
Since a custom HTTPS agent will make the use of properties
['ca', 'cert', 'key', 'passphrase']obsolete, maybe we should put a hint to the docs...?