Improve usability on embedded systems#2
Merged
jeffbencteux merged 3 commits intojeffbencteux:mainfrom Jan 11, 2025
Merged
Conversation
Contributor
cgzones
commented
Jan 6, 2025
cgzones
commented
- add option to avoid terminal escape sequences (used for coloring) in case they are not supported by the terminal in use
- differentiate between a systctl value having a non desired value and the key not existing on the current system
Owner
|
Idea is good. Checking the length of the value though is not enough it seems as errors provoked by other causes such as a permission denied are counted as "not found" values with your patch. This is my bad because we do not stop on |
* add option to avoid terminal escape sequences (used for coloring) in case they are not supported by the terminal in use * differentiate between a systctl value having a non desired value and the key not existing on the current system
Owner
|
Thanks for contributing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.