fixed an issue that was causing crashes if yubico request failed.#2
Open
genixpro wants to merge 1 commit intojedp:masterfrom
Open
fixed an issue that was causing crashes if yubico request failed.#2genixpro wants to merge 1 commit intojedp:masterfrom
genixpro wants to merge 1 commit intojedp:masterfrom
Conversation
|
This PR is critically important, please merge ! I have the same issue here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were getting crashes on the server that are result of the yubikey library:
,,index.js:272 - Uncaught Exception: TypeError: Cannot read property 'statusCode' of undefined,
,index.js:272 - at Object. (/home/ubuntu/sensibill-api-production/node_modules/yubikey/lib/yubikey.js:83:14),
,index.js:272 - at self.callback (/home/ubuntu/sensibill-api-production/node_modules/yubikey/node_modules/request/index.js:142:22),
,index.js:272 - at Request.EventEmitter.emit (events.js:95:17),
,index.js:272 - at ClientRequest.self.clientErrorHandler (/home/ubuntu/sensibill-api-production/node_modules/yubikey/node_modules/request/index.js:246:10),
,index.js:272 - at ClientRequest.EventEmitter.emit (events.js:95:17),
,index.js:272 - at CleartextStream.socketErrorListener (http.js:1547:9),
,index.js:272 - at CleartextStream.EventEmitter.emit (events.js:95:17),
,index.js:272 - at SecurePair. (tls.js:1389:19),
,index.js:272 - at SecurePair.EventEmitter.emit (events.js:92:17),
,index.js:272 - at SecurePair.maybeInitFinished (tls.js:982:10),
,,index.js:264 - About to exit with code: 255,
I just added in graceful handling of the error conditions causing the crash. Please pull and npm publish ASAP