Added download by id and support to send upload stream in req.filedata#7
Added download by id and support to send upload stream in req.filedata#7sachinhub wants to merge 3 commits intojdrouet:masterfrom sachinhub:master
Conversation
Current coverage is
|
|
@sachinhub thank you for the pull request but there is several problems. First, the code you have done is not in coffeescript. The second problem is that you don't make tests. Next, the prototype you need deffer from the standard loopback component storage (which is not really a problem). Could you fix it ? |
lib/index.js
Outdated
There was a problem hiding this comment.
When you store it in temporary location, you store it on the filesystem ? What is the difference between storing it in the filesystem and storing it in database ?
There was a problem hiding this comment.
Yes @jdrouet. We store in a folder on file system and then execute a virus scan script on it. The folder is quarantine.
Once the virus scan command returns okay, we upload it in database. We dont want to upload in database until it passes virus scanning tests.
There was a problem hiding this comment.
@sachinhub I think that you need to use the standard component storage first then upload it to database
Hi,
While using this module, we felt a need to add support for following functionalities -