This repository was archived by the owner on Oct 27, 2020. It is now read-only.
Open
Conversation
Current coverage is
|
Owner
|
@hellsan631 nice idea, but I think that it should be a parameter given to the component. I will introduce something like this next week ;) |
Author
|
I originally thought it weird that all of my api calls were caching except this one. For a better separation of concern, the caching should be given to express and your plugin should follow the filter/compression that's in place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows caching of images sent via download, and is very important to reduce bandwidth and for offline-capable web apps.
really loving the plugin btw :)
This change is