Skip to content
This repository was archived by the owner on Oct 27, 2020. It is now read-only.

added cache-control header#3

Open
hellsan631 wants to merge 1 commit intojdrouet:masterfrom
hellsan631:master
Open

added cache-control header#3
hellsan631 wants to merge 1 commit intojdrouet:masterfrom
hellsan631:master

Conversation

@hellsan631
Copy link

@hellsan631 hellsan631 commented Dec 9, 2015

This allows caching of images sent via download, and is very important to reduce bandwidth and for offline-capable web apps.

really loving the plugin btw :)


This change is Reviewable

@codecov-io
Copy link

Current coverage is 86.88%

Merging #3 into master will increase coverage by +0.11% as of 20971eb

@@            master      #3   diff @@
======================================
  Files            1       1       
  Stmts          121     122     +1
  Branches        13      13       
  Methods         27      27       
======================================
+ Hit            105     106     +1
  Partial          0       0       
  Missed          16      16       

Review entire Coverage Diff as of 20971eb

Powered by Codecov. Updated on successful CI builds.

@jdrouet
Copy link
Owner

jdrouet commented Dec 13, 2015

@hellsan631 nice idea, but I think that it should be a parameter given to the component. I will introduce something like this next week ;)

@hellsan631
Copy link
Author

I originally thought it weird that all of my api calls were caching except this one. For a better separation of concern, the caching should be given to express and your plugin should follow the filter/compression that's in place.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants