test(queue): add job metadata and queue message serialization tests#2050
Closed
test(queue): add job metadata and queue message serialization tests#2050
Conversation
Add unit tests for queue job metadata, message serialization, and validation errors. Files changed: - pkg/queue/jobs_test.go - add coverage for single and batch job metadata, queue message payloads, and path validation errors
Owner
Author
|
@copilot rebase and force push this and fix the merge conflicts from the rebase. |
5 tasks
Contributor
Refine queue job tests with subtests and additional description assertions while keeping coverage on queue message payloads and validation errors. Files changed: - pkg/queue/jobs_test.go - refine subtests and description assertions for single and batch jobs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pkg/queuewhile avoiding the previously-testedtypes.gofile.pkg/queue/jobs.go(randomized selection) because it contains job metadata, message serialization, and execution paths that exercise multiple components.Description
pkg/queue/jobs_test.gowith unit tests coveringSingleFileJobandBatchFilesJobmetadata,QueueMessagepayload serialization, andDescription()/ID()/Type()behaviors.QueueMessagepayloads are marshalled tojobpb.TranslationJobviaanypb.UnmarshalTousingproto.UnmarshalOptions.Executereturns path validation errors for relative (invalid) paths to exercise integration withsecurity.ValidateAndSanitizePathwithout changing production code.Testing
go test ./pkg/queuewhich completed successfully.pkg/queue/jobs_test.goand it passed locally under the repository test run.Files that may be involved or touched by other contributors to avoid conflicts:
pkg/queue/jobs.go,pkg/queue/queue.go,pkg/queue/message.go(protobuf wrappers),pkg/subtitles/translatefile.go,pkg/translator/translator.go,pkg/security/security.go, and the generated proto types underpkg/jobpb.Codex Task