Don't short-circuit in checking return code #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents loading old data when result is empty.
Contributor
Author
|
Checks fail on unrelated server issues. |
Contributor
Author
Looks like it could be related to usa-npn/rnpn#33 |
If no results or results but empty.
Why does one test suite fail while the others don't? Server issue?
Contributor
Author
|
Not sure why there are two failing tests now, they run fine on my end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when I made a query that warned me about "no results found", the response was still filled with data from a previous query.
This is because, in checking the result, the first condition was true and the short-circuit evaluation thus proceeded with the else branch without checking the second condition.
Instead, it should return empty when
Also updates the URL to NPN servers