Open
Conversation
df2e530 to
6f86bc1
Compare
sudodoki
reviewed
Dec 4, 2018
| @@ -1,18 +1,18 @@ | |||
| {{#progress}} | |||
| {{#options.progress}} | |||
Collaborator
There was a problem hiding this comment.
supposedly, this one would work without options as well, right? Did you update this to show people the possibility of using this or just to make something else work?
Collaborator
Author
There was a problem hiding this comment.
You're correct. I think it might make sense to try and make the progress and controls a bit less "magical" and a bit more like something you could write yourself (i.e. in a theme) without having to modify any of the cleaver core files.
For that reason I'd also suggest deprecating/removing the progress and options variables here (this change would be required to make that happen) at some point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This passes the
optionsdown to the slide template, so it's easier to extend it with new (customisable) functionality. Right now only the layout has access to the options, limiting where you can place new elements.Additionally made sure that the default values for
options.controlsandoptions.progressare properly passed down (i.e.truewhen not defined explicitly) to layout as well.It might make sense to remove the passing down of
controlsandprogressto the slide template as well, but I figured leaving it in is a bit better for backwards-compatibility.