feat: support embedding interface for all generate LLM models.#990
Merged
XuZhang99 merged 2 commits intojd-opensource:mainfrom Mar 10, 2026
Merged
feat: support embedding interface for all generate LLM models.#990XuZhang99 merged 2 commits intojd-opensource:mainfrom
XuZhang99 merged 2 commits intojd-opensource:mainfrom
Conversation
RobbieLeung
requested review from
DongheJin,
JimHsiung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the model hierarchy by removing the separate EmbeddingLM class and integrating its functionality into the CausalLM base class. This is a good architectural improvement that unifies the model interfaces and reduces code duplication. The changes are mostly correct, but I found a critical compilation error in one of the files.
yingxudeng
previously approved these changes
Mar 4, 2026
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
walsonyang
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: support common embedding's paramters like vllm/sgalng.