bugfix: fix mbox model(qwen2.5) multi round core in xattention#988
Merged
DragonFive merged 2 commits intojd-opensource:mainfrom Mar 7, 2026
Merged
bugfix: fix mbox model(qwen2.5) multi round core in xattention#988DragonFive merged 2 commits intojd-opensource:mainfrom
DragonFive merged 2 commits intojd-opensource:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
The pull request introduces support for qwen3_moe models in the is_llmrec_model_type function and integrates multi-round caching parameters (LlmRecMultiRoundParams) into the LlmModelImplBase and Qwen3MoeModelImpl forward passes. This change is crucial for enabling multi-round core functionality in xattention for these models. The added includes and logic for handling llmrec_params are appropriate for the stated bugfix.
XuZhang99
approved these changes
Mar 5, 2026
XuZhang99
reviewed
Mar 5, 2026
walsonyang
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the REC multi-round core path in xattention for the mbox (Qwen2.5-related) model flow by migrating the missing KV-cache
attachment logic.
Problem
In REC multi-round mode, the model forward path did not fully attach multi-round cache tensors (full_k/v and unshared_k/v) into
attention metadata for affected model implementations.
This could break or degrade multi-round behavior in xattention.
Changes
Impact
Files Changed
Notes