feat: add gtest coverage for cuda act_and_mul activation kernel.#987
Merged
yingxudeng merged 1 commit intojd-opensource:mainfrom Mar 9, 2026
Merged
feat: add gtest coverage for cuda act_and_mul activation kernel.#987yingxudeng merged 1 commit intojd-opensource:mainfrom
yingxudeng merged 1 commit intojd-opensource:mainfrom
Conversation
yingxudeng
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds gtest coverage for the act_and_mul CUDA kernel. The test implementation is solid, covering different activation modes and input dimensions to target various kernel code paths. I've identified a few areas for improvement: a missing linker dependency in the CMakeLists.txt file which could cause build failures, and an opportunity to extend test coverage to include the bfloat16 data type, which is supported by the kernel. I've left specific suggestions to address these points.
yingxudeng
force-pushed
the
feat/gtest_active
branch
from
3ca76ca to
2212162
Compare
zhang-minchao
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.