bugfix: fix mtp worker empty run issue for deepseek dp.#1008
Merged
phantomlei3 merged 1 commit intojd-opensource:mainfrom Mar 7, 2026
Merged
bugfix: fix mtp worker empty run issue for deepseek dp.#1008phantomlei3 merged 1 commit intojd-opensource:mainfrom
phantomlei3 merged 1 commit intojd-opensource:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug related to handling empty runs in a data-parallel setup for MTP workers. The changes introduce necessary checks to gracefully handle cases where a worker receives no sequences to process. In mtp_worker_impl.cpp, a guard is added to update_input_by_last_step_output to exit early if there are no sequences or embedding IDs. Similarly, in worker_impl.cpp, step_async is updated to verify that there are tokens to process before attempting to update the input. These changes appear to be a correct and robust solution for the issue. I have reviewed the changes and found no issues of high or critical severity.
RobbieLeung
approved these changes
Mar 6, 2026
XuZhang99
approved these changes
Mar 6, 2026
walsonyang
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.