Skip to content

feat: build sequence parallel prerequisites for mlu.#1001

Merged
phantomlei3 merged 5 commits intojd-opensource:mainfrom
phantomlei3:feat/ds-v32-sp-prereq
Mar 9, 2026
Merged

feat: build sequence parallel prerequisites for mlu.#1001
phantomlei3 merged 5 commits intojd-opensource:mainfrom
phantomlei3:feat/ds-v32-sp-prereq

Conversation

@phantomlei3
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces foundational changes to support sequence parallelism, primarily for MLU devices. Key changes include adding a sequence-parallel communication group, refactoring the gather collective into an asynchronous pattern, and significantly enhancing ColumnParallelLinear and RowParallelLinear to optionally store full weights even when participating in a tensor-parallel group. The overall architecture is sound and forward-looking. However, I've identified a few critical issues in linear.cpp where std::optional values are dereferenced without prior checks, which could lead to runtime crashes. My review provides specific suggestions to add these necessary safety checks.

Comment thread xllm/core/layers/common/linear.cpp
Comment thread xllm/core/layers/common/linear.cpp
Comment thread xllm/core/layers/common/linear.cpp
Comment thread xllm/core/layers/common/linear.cpp Outdated
@phantomlei3 phantomlei3 force-pushed the feat/ds-v32-sp-prereq branch from bdf6507 to 0742060 Compare March 6, 2026 08:19
@phantomlei3 phantomlei3 merged commit b3ed0ee into jd-opensource:main Mar 9, 2026
18 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants