Fix iOS7 and Smoke notifications when call / hotspot bar displayed#28
Open
mrkhingston wants to merge 2 commits intojcoleman:masterfrom
Open
Fix iOS7 and Smoke notifications when call / hotspot bar displayed#28mrkhingston wants to merge 2 commits intojcoleman:masterfrom
mrkhingston wants to merge 2 commits intojcoleman:masterfrom
Conversation
Author
|
Just a follow up - I got landscape mode to work in the demo app by also taking the 'no status bar' fix from the PR created by @apiech So I can now say that: yes - the fix works in both portrait and landscape mode on iOS 7 and 8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't have access to any iOS 6 device / simulator so I haven't been able to test this there but I can confirm that on iOS 7 & 8 this fixes the banner so that it appears from the top of the screen.
I didn't know how to fix the rotating iOS 6 style banner presenter.
I attempted to test this in portrait and landscape orientations, but even without this change, the demo project is very broken for me when run in landscape orientation. All of the types of notifications display off screen.