Xray functions and examples for particle lightcones#23
Open
Will-McD wants to merge 51 commits intojchelly:masterfrom
Open
Xray functions and examples for particle lightcones#23Will-McD wants to merge 51 commits intojchelly:masterfrom
Will-McD wants to merge 51 commits intojchelly:masterfrom
Conversation
Included rotation functions for smoothed map making. Now can input angles (theta, phi) to rotate particle coordinates on the sky before placing them into the map. Rotating the particles' coordinates prior to placing them in the map resolves some of the problems that can be introduced by rotating the smoothed maps themselves when neighbouring pixels have a high variance.
X-ray interpolation and computation functions for the particle lightcone. This differs from the Snapshot version by allowing a multiple redshifts at once
xray_calculator included
Added comsology object and xray particle filters
Added functions to compute X-ray luminosities and flux for the particle lightcone
minor edits
Example of computing X-ray values for the particle lightcone
Included plots showing the distribution for photons and energies outputs
formatting
Formatting
included new Xray functions and classes.
fixed axes titles
as the title says
Fixed axes labels
- Now passes snapshot directory instead of snapshot .h5 file path - Extra functions to compute radius from redshifts
Now includes an example plot.
follows updates to cosmology functions
removed unneeded comments and print messages
small doc string clean up
made exceptions more specific and robust
fixed missing z_at_value function, from astropy.cosmology import z_at_value
fixed problem with not giving correct output names to X-ray luminosity values when only one observation band is given.
included convolved X-ray units into the missing units dictionary
now includes X-ray requirements
Now includes X-ray computation requirements
Was removing the actual particle data values earlier than necessary, instead of only removing the .ndarray_view() version to minimise overhead
Using the particle lightcones write a set of X-ray all-sky maps, one map per observation band, for a given X-ray observation type.
example script to make an all-sky map of X-ray emission of a given type in all three FLAMINGO energy bands
bash script for x-ray map example
edits to the code comments and removed lines that are not necessary.
added comments to point user towards where to build needed virtual environment.
Small changes to make cleaner example code. Moved excess functions to xray_map_all_bands.py to simplify this example.
Can now read a dictionary input for the emissivity table or a string with the path to the table itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functions to compute X-ray luminosity and flux values for particles in the lightcones.
For an example on how to compute X-ray values for a selection of gas particles see ./examples/xray_emission_in_a_pencil_beam.py