Document consolidation rationale for configuration module#284
Document consolidation rationale for configuration module#284
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull Request Overview
This PR documents the consolidation rationale for the configuration module by adding ADR-BACK-006. The consolidation eliminates the duplicate Spanish configuracion app while maintaining backward compatibility by mapping Spanish routes to the English configuration module implementation.
Key changes:
- New ADR-BACK-006 documents the decision to unify configuration functionality
- Updated ADR index to reference the new consolidation record
- Removed legacy Spanish app (
configuracion) entirely - all models, views, serializers, services, URLs, and migrations - Added new endpoints to English app: detail view, history, and audit
- Added comprehensive test coverage for consolidated functionality
Reviewed Changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/gobernanza/adr/ADR-BACK-006-unificacion-configuracion.md | New ADR documenting the consolidation decision and rationale |
| docs/backend/adr/README.md | Updated ADR index to include reference to ADR-BACK-006 |
| api/callcentersite/tests/unit/configuration/test_views_historial.py | New tests validating detail, history, and audit views |
| api/callcentersite/tests/unit/configuration/test_consolidation.py | Tests ensuring Spanish routes resolve to English implementation |
| api/callcentersite/callcentersite/urls.py | Routes Spanish path to English module with namespace |
| api/callcentersite/callcentersite/settings/base.py | Removed legacy configuracion app from INSTALLED_APPS |
| api/callcentersite/callcentersite/apps/configuration/views.py | Added GET method to detail view, new history and audit views |
| api/callcentersite/callcentersite/apps/configuration/urls.py | Added routes for history and audit endpoints |
| api/callcentersite/callcentersite/apps/configuration/services.py | Added service methods for detail retrieval, history, and audit |
| api/callcentersite/callcentersite/apps/configuracion/* | Complete removal of legacy Spanish app files |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…cion-and-configuration-06-57-13
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Summary
Testing
Codex Task