Skip to content

Refactor request to Axios #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbrooksuk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor request to Axios #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a73f488
Refactor request to Axios
jbrooksuk Oct 14, 2024
108e916
Apply fixes from StyleCI
StyleCIBot Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions lib/summary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { convertHTMLToText, getTitle } from './helpers/html.js'
import { isValidUrl } from './helpers/urls.js'
import { default as request } from 'request'
import axios from 'axios'
import {
onlyGetSentences,
splitContentToSentences,
Expand All @@ -14,18 +14,22 @@ import {

export const summarizeFromUrl = function (url, callback) {
if (isValidUrl(url)) {
request.get(url, function (error, response, body) {
let title = getTitle(body)
let text = convertHTMLToText(body)
let content = onlyGetSentences(text)
return summarize(title, content, (err, result, dict) => {
if (err) {
callback(err, result, dict)
} else {
axios
.get(url)
.then(response => {
const body = response.data

let title = getTitle(body)
let text = convertHTMLToText(body)
let content = onlyGetSentences(text)

return summarize(title, content, (err, result, dict) =>
callback(err, result, dict)
}
)
})
.catch(error => {
callback(true, 'Failed to fetch the url. Please try again later.')
})
})
} else {
callback(
true,
Expand Down
Loading