Open
Conversation
we should not copy cope form other repos with the same name so at least rename it. i do not want to put whole mochiweb as a dependancy intentionally.
dsrosario
pushed a commit
to dsrosario/rabbit_common
that referenced
this pull request
Jun 25, 2016
More sensible error messages for connection-level exceptions on running connections
|
This would be great! Any way this could be merged? |
|
As Bumping this merge request |
|
Can we get this merged? It's caused a problem for us, and I suspect it'll catch a few other people out as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we should not copy code form other repos with the same name so at least rename it.
i do not want to put whole mochiweb as a dependancy intentionally.
Otherwise it's not possible to use both rabbit_common and original mochiweb