Skip to content

Added whatsnew headers in JIRA issue#259

Open
gastaldi wants to merge 2 commits into
jbosstools:mainfrom
gastaldi:patch-1
Open

Added whatsnew headers in JIRA issue#259
gastaldi wants to merge 2 commits into
jbosstools:mainfrom
gastaldi:patch-1

Conversation

@gastaldi
Copy link
Copy Markdown

@gastaldi gastaldi commented Mar 25, 2015

Needs some testing


This change is Reviewable

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the idea, but component-fix version wont always be same as jbide fix version nor will the component id match perfectly ;/

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add that info to the component array above?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see what you mean, maybe having a placeholder in the file contents instead?

@alexeykazakov
Copy link
Copy Markdown
Contributor

File "createnewandnoteworthy.py", line 85, in <module>
    new_file_contents = '= '+ name +' What\'s New\n:page-layout: whatsnew\n:page-component_id: '+comps+'\n:page-component_version: '+jbide_fixversion+'\n:page-product_id: jbt_core\n:page-product_version: '+jbide_fixversion
TypeError: cannot concatenate 'str' and 'set' objects

@gastaldi
Copy link
Copy Markdown
Author

I confess I haven't tested it locally. I think it needs to call the join function?

Em 25/03/2015, às 21:08, Alexey Kazakov notifications@github.com escreveu:

File "createnewandnoteworthy.py", line 85, in
new_file_contents = '= '+ name +' What's New\n:page-layout: whatsnew\n:page-component_id: '+comps+'\n:page-component_version: '+jbide_fixversion+'\n:page-product_id: jbt_core\n:page-product_version: '+jbide_fixversion
TypeError: cannot concatenate 'str' and 'set' objects

Reply to this email directly or view it on GitHub.

@alexeykazakov
Copy link
Copy Markdown
Contributor

I guess so. But my python knowledge is very poor ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants