Skip to content

ci(codeql): switch to advanced workflow + drop default setup#213

Merged
jbdevprimary merged 1 commit into
mainfrom
ci/codeql-advanced-setup
May 6, 2026
Merged

ci(codeql): switch to advanced workflow + drop default setup#213
jbdevprimary merged 1 commit into
mainfrom
ci/codeql-advanced-setup

Conversation

@jbdevprimary
Copy link
Copy Markdown
Contributor

Disables default-setup CodeQL (which only runs on push to default branch and weekly) and replaces it with a custom workflow that runs on push to all branches.

This unblocks pushes to feature branches when the Enterprise "PRs" ruleset's code_scanning rule is active — default-setup never runs against feature-branch pushes, so the rule rejects them indefinitely with "Waiting for Code Scanning results".

Maintained centrally at github.com/jbdevprimary/gh-fleet-sync. Do not edit the workflow in place — drift detection runs on every fan-out and will flag it.

@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

Warning

Rate limit exceeded

@jbdevprimary has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 58 minutes and 34 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b2234202-9541-4845-9a58-1a181c079ab0

📥 Commits

Reviewing files that changed from the base of the PR and between 8e789d3 and ea3f8cd.

📒 Files selected for processing (1)
  • .github/workflows/codeql.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/codeql-advanced-setup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@amazon-q-developer amazon-q-developer Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

This PR adds an advanced-setup CodeQL workflow to replace default-setup, enabling CodeQL scans on all branch pushes to satisfy Enterprise "PRs" ruleset requirements. The workflow is well-structured with appropriate permissions, concurrency controls, and trigger configuration.

Critical Issue

Security vulnerability identified: GitHub Actions are pinned to mutable major version tags (@V3, @v4) instead of immutable commit SHAs, creating a supply chain attack vector. This must be addressed before merge.

The workflow correctly:

  • Configures triggers for push (with branch exclusions), pull requests, scheduled runs, and manual dispatch
  • Implements concurrency controls to cancel stale runs
  • Uses minimal required permissions
  • Analyzes both javascript-typescript and actions languages with appropriate build modes

You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

Comment thread .github/workflows/codeql.yml
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 85.34% (🎯 80%) 4595 / 5384
🔵 Statements 84.48% (🎯 80%) 4966 / 5878
🔵 Functions 82.83% (🎯 80%) 1491 / 1800
🔵 Branches 74.68% (🎯 73%) 2823 / 3780
File CoverageNo changed files found.
Generated in workflow #625 for commit ea3f8cd by the Vitest Coverage Report Action

@jbdevprimary jbdevprimary merged commit 6b05da7 into main May 6, 2026
12 of 17 checks passed
@jbdevprimary jbdevprimary deleted the ci/codeql-advanced-setup branch May 6, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant