fix: improve DOCX spacing for dates and paragraphs#112
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the DOCX generation script to enhance the visual presentation and readability of the generated documents. It addresses inconsistencies in date alignment and improves paragraph spacing, resulting in a more polished and professional document layout. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (9)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Review Summary
The changes in this PR correctly improve DOCX document spacing and date alignment. The code modifications are functionally sound with no blocking issues identified.
Key Changes Validated:
- Replaced unreliable
TabStopPosition.MAXwith explicitRIGHT_TAB_POSITIONconstant (10800 twips) - Increased paragraph spacing for better readability (summary: 120→200 twips, job summary: 60→100 twips)
- Properly removed unused
TabStopPositionimport - All replacements applied consistently across both usage locations
Merge Status: ✅ No blocking defects found. The implementation is correct and ready to merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
There was a problem hiding this comment.
Code Review
This pull request aims to improve spacing and alignment in the generated DOCX resume. The changes are well-intentioned, especially the introduction of a constant for the right tab stop position. However, I've found a potential issue with the calculation of this constant's value which may not produce the desired alignment. My review includes a suggestion to correct this calculation for better accuracy and maintainability.
| // Letter page (12240 twips) minus 720 left + 720 right margins | ||
| const RIGHT_TAB_POSITION = 10800 |
There was a problem hiding this comment.
The calculation for RIGHT_TAB_POSITION appears to be incorrect. According to the OOXML specification, tab stop positions are measured from the left edge of the page. With a Letter page width of 12240 twips and a right margin of 720 twips, the right-aligned tab stop should be at 12240 - 720 = 11520 to align correctly with the right margin.
The current value of 10800 corresponds to the text area's width (12240 - 720 - 720), which would place the tab stop 0.5 inches before the right margin.
For improved robustness, I also suggest explicitly setting the page size to 'Letter' within the document properties. This avoids reliance on the docx library's default (which may be A4) and ensures consistent output.
// Right tab at margin: page width (12240) - margin (720), from left edge.
const RIGHT_TAB_POSITION = 12240 - 720;|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
25 similar comments
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Resume PDF and DOCX have been automatically regenerated from updated source files. |
|
Superseded by PR #113 (Astro migration) which replaced the Vite-based resume generator with Astro + pandoc. The DOCX spacing concerns addressed here are handled by the new pipeline. |
Summary
TabStopPosition.MAXwith explicit10800twip right tab (letter page width minus margins) for reliable date alignment🤖 Generated with Claude Code