fix(ci): disable build in semantic-release action, build in CI#22
Conversation
Root cause: python-semantic-release Docker container doesn't have uv installed Build command failed with exit code 127 (command not found) Solution: Decouple building from versioning - Set build:false in python-semantic-release action - Add separate build step after version bump (in CI environment with uv) - Remove build_command from pyproject.toml - Simplified commit message template This follows the separation of concerns pattern and ensures builds happen in the properly configured CI environment.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a CI failure by moving the package build step out of the python-semantic-release action and into a dedicated CI step. The corresponding changes in pyproject.toml to disable the build command are appropriate. I have raised one point of feedback concerning the removal of the template_dir configuration for the changelog, as this could be an unintended change that alters the changelog format. Otherwise, the changes are a solid improvement to the release workflow.
|
|
||
| # Changelog configuration | ||
| [tool.semantic_release.changelog] | ||
| template_dir = "templates" |
There was a problem hiding this comment.
The removal of template_dir causes python-semantic-release to revert to its default changelog template, which will likely alter the formatting of CHANGELOG.md in future releases. This change appears unrelated to the primary goal of fixing the CI build process and might be an unintended side-effect. While using the default template may be acceptable, this is a significant change to the project's release artifact generation that should be deliberate.
🤖 Agent Handoff: @cursorEnterprise Dashboard: jbcom/control-center#505 ContextCI fix for semantic-release. Part of extended-data-library 1.0 stabilization. Your Responsibilities
Related
Please respond with status. |
|
Addressing @gemini-code-assist's feedback: The |
|
Thanks for the detailed explanation, @jbdevprimary! Your reasoning for removing Regarding the update to use |
Problem
PR #21 failed during release with:
Root cause: The Docker container doesn't have installed.
Solution
Decouple building from versioning:
Benefits
✅ Builds happen in properly configured CI environment
✅ Follows separation of concerns pattern
✅ semantic-release focuses on versioning only
✅ No dependency on tools in action's container
Testing
This is a
fix:commit - will trigger patch release when merged.Flow:
Refs #21
Note
Moves package build out of
python-semantic-releaseand into the CI workflow to ensure builds run in the configured environment.ci.yml, setpython-semantic-releasebuild: falseand add a conditionaluv buildstep after versioning; keep PyPI and GitHub Releases publish steps gated onreleasedpyproject.toml, removebuild_command, simplify releasecommit_message, and dropchangelog.template_dirto align with CI-driven buildsWritten by Cursor Bugbot for commit 08de718. This will update automatically on new commits. Configure here.