fix(ci): correct artifact paths for monorepo structure#54
Conversation
The CI build was failing because the `build` job was not producing a `dist` directory at the root of the repository. Instead, each package in the monorepo was creating its own `dist` directory within the `packages` directory. This commit fixes the CI workflow by: - Changing the artifact upload path in the `build` job to `packages/**/dist` to correctly capture all build outputs. - Updating the artifact download path in the `test` and `release` jobs to `packages` to ensure the correct file structure is recreated for dependent jobs.
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
🤖 AI Code ReviewSummaryChanges artifact paths from monolithic Issues🔴 Critical: Download artifact path mismatch. Upload uses 🟠 High: Download action downloads to Suggestions⚪ Low: Consider using ⚪ Low: Add comments explaining the monorepo structure change for future maintainers. Reviewed by Ecosystem Reviewer using glm-4.6:cloud |
🤖 AI Code ReviewSummaryReview completed ✅ No Issues FoundAdditional Comments{
"summary": "Changed artifact paths from 'dist' to 'packages/**/dist' and adjusted download path to 'packages', but artifact upload and download names and paths are mismatched.",
"issues": [
{
"severity": "critical",
"category": "bug",
"message": "Artifact upload path 'packages/**/dist' doesn't match the expected test job's structure which expects artifacts at root 'dist'",
"suggestion": "Ensure consistency between upload and download paths. Either change upload to 'packages/**/dist' and download to same structure, or revert to flat 'dist'"
},
{
"severity": "high",
"category": "bug",
"message": "Test job downloads to 'packages' but original workflow expected 'dist', breaking the test step's path assumptions",
"suggestion": "Update test steps to handle artifacts from 'packages' directory or maintain download path as 'dist'"
}
],
"approval": "request_changes",
"comments": "The path changes appear inconsistent and could break artifact handling. The upload path includes nested packages but download expects flat artifacts. Please verify the intended artifact structure."
}Reviewed by Control Center using Ollama GLM 4.6 |
|
jbdevprimary
added
auto-merge
jules-pr
2 participants
Summary
Fix CI failure by correcting artifact upload/download paths for the monorepo structure.
Changes
dist→packages/**/dist(capture all package builds)dist→packages(restore correct directory structure)Source
This fix was identified by Jules AI (session
13997878939372578345) but the session completed without creating a PR. The patch was manually extracted and applied.Related
🤖 Changes identified by Jules AI, PR created by control-center