Skip to content

use new context api#12

Open
jnsdls wants to merge 1 commit intojavivelasco:masterfrom
jnsdls:modern-context
Open

use new context api#12
jnsdls wants to merge 1 commit intojavivelasco:masterfrom
jnsdls:modern-context

Conversation

@jnsdls
Copy link
Copy Markdown

@jnsdls jnsdls commented Dec 21, 2018

  • updated dependencies
  • bumped required react version
  • used new context api
  • tests are passing
  • no more warnings in <StrictMode/>

@jnsdls
Copy link
Copy Markdown
Author

jnsdls commented Dec 21, 2018

@javivelasco please have a look when u have a minute and let me know if there's anything you would like me to change

@jgoux
Copy link
Copy Markdown

jgoux commented Jan 24, 2019

I'd love this PR and the other to get merged. 🙏

@jnsdls
Copy link
Copy Markdown
Author

jnsdls commented Jan 24, 2019

fwiw I have been using this branch in production ever since creating it and there have been 0 issues so far.

@veeramarni
Copy link
Copy Markdown

@javivelasco can this PR be merged?

@kiurchv
Copy link
Copy Markdown

kiurchv commented Jan 13, 2020

@javivelasco More than year passed. Any chance to get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants