Skip to content
This repository was archived by the owner on Feb 17, 2019. It is now read-only.

overflowing_literals false positive#2

Open
ollie27 wants to merge 1 commit intojavierbg:masterfrom
ollie27:patch-1
Open

overflowing_literals false positive#2
ollie27 wants to merge 1 commit intojavierbg:masterfrom
ollie27:patch-1

Conversation

@ollie27
Copy link

@ollie27 ollie27 commented Jan 17, 2019

In a future version of Rust the overflowing_literals lint will become deny by default. See rust-lang/rust#55632. When checking for breakage in crates uploaded to crates.io it was discovered that this crate will no longer compile thanks to this lint. The error produced is here. This PR should fix the false positive.

In a future version of Rust the `overflowing_literals` lint will become deny by default. See rust-lang/rust#55632. When checking for breakage in crates uploaded to crates.io it was discovered that this crate will no longer compile thanks to this lint. The error produced is [here](https://crater-reports.s3.amazonaws.com/pr-55632/try%23dc13be39fae8d4c607889b27de374b52586485a3/gh/javierbg.DaMaGed/log.txt). This PR should fix the false positive.
@javierbg
Copy link
Owner

javierbg commented Feb 17, 2019

I may resume development sometime soon, but this repo has now been substituted by another one on Gitlab, since I'm migrating to work there. I should have archived this long ago. And also, how is this on crates.io?

I don't really understand what problem it's trying to solve, and for what I've read in the issue linked, this may just be a false positive. In any case, any further issues should be directed to the Gitlab repo mentioned before. I'll archive this repo now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants