Implement Person interface and concrete classes, random greeting logi… #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c, and refactor getName to getFirstName
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the simple “Hello, World!” with a dynamic greeting system by defining a Person interface and multiple implementations, then randomly instantiating and greeting them. Key changes include:
- Introduce an abstract
Personinterface and concrete classes (Moe,Larry,Curley,Shemp). - Implement random generation of 3–10
Personobjects and print personalized greetings. - Refactor
getNametogetFirstNameand keep a legacyprint_hello_worldhelper.
Comments suppressed due to low confidence (1)
main.cpp:55
- The function
print_hello_worldis defined but never used; consider removing it or documenting its intended usage.
void print_hello_world() {
| std::uniform_int_distribution<> type_dist(0, 3); | ||
| int num_people = num_dist(gen); | ||
| for (int i = 0; i < num_people; ++i) { | ||
| switch (type_dist(gen)) { |
There was a problem hiding this comment.
Add a default case or an assertion inside the switch to handle unexpected values and make the intent explicit.
|
|
||
| int main(int argc, char* argv[]) { | ||
| (void)argc; (void)argv; | ||
| std::vector<std::unique_ptr<Person>> people; |
There was a problem hiding this comment.
Reserve the vector capacity with people.reserve(num_people) before the loop to avoid repeated reallocations.
| std::vector<std::unique_ptr<Person>> people; | ||
| std::random_device rd; | ||
| std::mt19937 gen(rd()); | ||
| std::uniform_int_distribution<> num_dist(3, 10); |
There was a problem hiding this comment.
[nitpick] Extract the magic numbers 3 and 10 into named constants to clarify their purpose and improve readability.
Suggested change
| std::uniform_int_distribution<> num_dist(3, 10); | |
| std::uniform_int_distribution<> num_dist(MIN_PEOPLE, MAX_PEOPLE); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…c, and refactor getName to getFirstName