fix: resolve build-breaking playwright import and clean up lint warnings#1
Open
devin-ai-integration[bot] wants to merge 6 commits into
Open
fix: resolve build-breaking playwright import and clean up lint warnings#1devin-ai-integration[bot] wants to merge 6 commits into
devin-ai-integration[bot] wants to merge 6 commits into
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
e43c479 to
7294062
Compare
- Fix explicit any in step-executor.ts catch clause - Suppress set-state-in-effect in step-node.tsx (needed to sync local text) - Remove unused imports in demo-site components - Convert actionTypes const to type-only in use-toast.ts files Co-Authored-By: Jason ⚡ <jkim94960@gmail.com>
Co-Authored-By: Jason ⚡ <jkim94960@gmail.com>
…dCheck) Co-Authored-By: Jason ⚡ <jkim94960@gmail.com>
…tep-node (setState in effect) Co-Authored-By: Jason ⚡ <jkim94960@gmail.com>
Co-Authored-By: Jason ⚡ <jkim94960@gmail.com>
…PORT_VERSION, buildFallbackAnalysis) Co-Authored-By: Jason ⚡ <jkim94960@gmail.com>
7294062 to
1222fa7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes lint errors, warnings, and dead code across the codebase (14 files, net -32 lines).
Lint error fixes:
canvas-viewport.tsx: Fixed ref access during render — addedisPanningStatestate variable so cursor style updates reactively instead of readingpanState.currentduring renderstep-executor.ts: Replacedcatch (err: any)withcatch (err: unknown)and properinstanceof Errorcheckstep-node.tsx: Suppressedreact-hooks/set-state-in-effecton thesetTextcall that syncs local text when parent description changesDead code removal:
engine.ts: Removed unusedrunAnalysisWithTimeoutfunction (~30 lines),analyzeStepFailureimport,FailingActionSummarytype import, andFAILURE_ANALYSIS_TIMEOUT_MSconstantLint warning fixes (unused imports/variables):
Badge,Loader2,KeyRound,Sparkles,ShieldCheck,Plus,User,Link,Label,CardDescription,products,indexparamactionTypesconst to type-only in bothuse-toast.tsfilesorderIdparam inhandleReorderReview & Testing Checklist for Human
npm run lintpasses with zero errors/warningsrunAnalysisWithTimeoutdoesn't break any execution paths (it was dead code — defined but never called)Notes
@vercel/analytics,FieldMessageexport, type mismatches inshop/page.tsx,chart.tsx). These are upstream issues onmainnot introduced by this PR.npm run lintis fully clean (0 errors, 0 warnings).Link to Devin session: https://app.devin.ai/sessions/9d40b31573d747a781316e38e5b6a887
Requested by: @jask1m