Fall back to ftp.gnu.org when ftpmirror.gnu.org serves a bad file#231
Merged
Conversation
ftpmirror.gnu.org redirects to a random mirror; one occasionally serves a corrupt or unrelated file (recent CI failure: autoconf-2.72.tar.xz checksum mismatch). Wrap the autoconf/automake fetches in a helper that retries the canonical ftp.gnu.org source on either HTTP failure or checksum mismatch, and use curl -f so error pages are not saved as the artifact.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ftpmirror.gnu.orgredirects to a random mirror; one occasionally serves a corrupt or unrelated file. Recent CI failure on PR Bump NUnit from 4.5.1 to 4.6.0 #229 (and others) was an autoconf-2.72.tar.xz sha256 mismatch.ftp.gnu.orgsource on HTTP failure or checksum mismatch.curl -fso HTTP error pages are not saved as the artifact and then fed totar.Test plan
ftpmirror.gnu.org, normal path).Summary by cubic
Add a robust GNU source fetch in CI to stop flaky checksum failures by falling back to
https://ftp.gnu.orgwhenhttps://ftpmirror.gnu.orgserves a bad file. Also usecurl -fso HTTP error pages aren’t saved and fed totar.fetch_gnu()in.github/workflows/build.ymlthat triesftpmirror.gnu.orgfirst, thenftp.gnu.org, verifies SHA-256, and retries on failure.curl -fsSLwith retries and removed bad artifacts on checksum mismatch.Written for commit e5bc055. Summary will update on new commits.