fix(loop): preserve domain-gated readiness#21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
LoopWorkerreadiness ordering when auto-ready is disabled.SetReady(true)call from being overwritten by startup bookkeepingWhy
With
WithLoopAutoReady(false), readiness is owned by the loop. The loop should be able to callWorkerRuntime.SetReady(true)after domain warmup and have that signal stick.The previous startup order launched the loop goroutine before calling
SetReady(false). Under race-mode scheduling, the loop could mark itself ready first, thenStartcould overwrite readiness back to false.Verification
make testmake test-race