Fix url check error resulting in 400 when strategy is used in an Express router#72
Open
fchu wants to merge 1 commit intojaredhanson:masterfrom
Open
Fix url check error resulting in 400 when strategy is used in an Express router#72fchu wants to merge 1 commit intojaredhanson:masterfrom
fchu wants to merge 1 commit intojaredhanson:masterfrom
Conversation
in an Express Router, which changes the req.url string (see http://expressjs.com/en/4x/api.html#req.originalUrl for details)
|
@jaredhanson i think we should merge this.. its causing error in digest auth and not giving any proper error message, but just bad request, it took me hours before finally digging down the code to later find that, that error was due to this... |
|
+1 on this PR. It also took me hours to debug |
|
This is a duplicate of #49 – either solution works, it would be nice to merge one of them though :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happens because the Express router, changes the value of req.url to strip the mount point.
Using req.originalUrl should fix the issue ( Fixes #43 )
(see http://expressjs.com/en/4x/api.html#req.originalUrl for details)