Skip to content

feat: support max-* screen prefix variants #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Simek wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: support max-* screen prefix variants #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d70991
feat: support `max-*` screen prefix variants
Simek Dec 26, 2025
62a0e8f
match equal size according to MQ, add custom breakpoint test
Simek Dec 26, 2025
c257efe
Merge branch 'master' into @simek/feat-support-max-breakpoint-variants
jaredh159 Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/UtilityParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,25 @@ export default class UtilityParser {

// loop through the prefixes ONE time, extracting useful info
for (const prefix of prefixes) {
if (widthBreakpoints[prefix]) {
if (prefix.startsWith(`max-`) && prefix.slice(4) in widthBreakpoints) {
const breakpoint = widthBreakpoints[prefix.slice(4)];
if (!breakpoint) {
this.isNull = true;
continue;
}

const windowWidth = device.windowDimensions?.width;
if (!windowWidth) {
this.isNull = true;
continue;
}

if (windowWidth <= breakpoint[0]) {
this.incrementOrder();
} else {
this.isNull = true;
}
} else if (widthBreakpoints[prefix]) {
const breakpointOrder = widthBreakpoints[prefix]?.[2];
if (breakpointOrder !== undefined) {
this.order = (this.order ?? 0) + breakpointOrder;
Expand Down
3 changes: 3 additions & 0 deletions src/__tests__/prefix-match.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ describe(`tw.prefixMatch()`, () => {
expect(tw.prefixMatch(`md`)).toBe(true);
expect(tw.prefixMatch(`lg`)).toBe(true);
expect(tw.prefixMatch(`xl`)).toBe(false);
expect(tw.prefixMatch(`max-md`)).toBe(false);
expect(tw.prefixMatch(`max-lg`)).toBe(false);
expect(tw.prefixMatch(`max-xl`)).toBe(true);
expect(tw.prefixMatch(`landscape`)).toBe(true);
expect(tw.prefixMatch(`portrait`)).toBe(false);
});
Expand Down
28 changes: 28 additions & 0 deletions src/__tests__/tw.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,40 @@ describe(`tw`, () => {
expect(tw.style(utilities)).toMatchObject({ fontSize: 24 });
tw.setWindowDimensions({ width: 1280, height: 500 });
expect(tw.style(utilities)).toMatchObject({ fontSize: 30 });
// default max breakpoints variants
const maxUtilities = `text-3xl max-lg:text-2xl max-md:text-lg max-sm:text-base`;
expect(tw.style(maxUtilities)).toMatchObject({ fontSize: 30 });
tw.setWindowDimensions({ width: 500, height: 500 });
expect(tw.style(maxUtilities)).toMatchObject({ fontSize: 16 });
tw.setWindowDimensions({ width: 639, height: 500 });
expect(tw.style(maxUtilities)).toMatchObject({ fontSize: 16 });
tw.setWindowDimensions({ width: 640, height: 500 });
expect(tw.style(maxUtilities)).toMatchObject({ fontSize: 16 });
tw.setWindowDimensions({ width: 767, height: 500 });
expect(tw.style(maxUtilities)).toMatchObject({ fontSize: 18 });
tw.setWindowDimensions({ width: 768, height: 500 });
expect(tw.style(maxUtilities)).toMatchObject({ fontSize: 18 });
tw.setWindowDimensions({ width: 1023, height: 500 });
expect(tw.style(maxUtilities)).toMatchObject({ fontSize: 24 });
tw.setWindowDimensions({ width: 1024, height: 500 });
expect(tw.style(maxUtilities)).toMatchObject({ fontSize: 24 });
tw.setWindowDimensions({ width: 1279, height: 500 });
expect(tw.style(maxUtilities)).toMatchObject({ fontSize: 30 });
tw.setWindowDimensions({ width: 1280, height: 500 });
expect(tw.style(maxUtilities)).toMatchObject({ fontSize: 30 });
// custom breakpoints
tw = create({ theme: { screens: { custom: `555px` } } });
tw.setWindowDimensions({ width: 554, height: 500 });
expect(tw`text-xs custom:text-lg`).toMatchObject({ fontSize: 12 });
tw.setWindowDimensions({ width: 555, height: 500 });
expect(tw`text-xs custom:text-lg`).toMatchObject({ fontSize: 18 });
// custom max breakpoints
tw.setWindowDimensions({ width: 554, height: 500 });
expect(tw`text-xl max-custom:text-sm`).toMatchObject({ fontSize: 14 });
tw.setWindowDimensions({ width: 555, height: 500 });
expect(tw`text-xl max-custom:text-sm`).toMatchObject({ fontSize: 14 });
tw.setWindowDimensions({ width: 556, height: 500 });
expect(tw`text-xl max-custom:text-sm`).toMatchObject({ fontSize: 20 });
});

test(`multiple media queries`, () => {
Expand Down