Added missing comparison operators (below add level) and tertiary operator (below comparison level)#4
Open
aleferri wants to merge 3 commits intojapplegame:masterfrom
Open
Added missing comparison operators (below add level) and tertiary operator (below comparison level)#4aleferri wants to merge 3 commits intojapplegame:masterfrom
aleferri wants to merge 3 commits intojapplegame:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the comparison operators and the tertiary operator, they do not add too much code.
Also, i added the expected tests, and everything is green.
Sorry for all of the noise, but my editor is on autoformat-on-save and so everything got formatted, Please consider a global code format on your own repo, so i can rebase and "clean" the commit.