uvx package: Use platform.uname().machine#139
Merged
paulgb merged 1 commit intojamsocket:mainfrom Apr 17, 2025
Merged
Conversation
Member
|
Thanks for this! Looks like the github action failure is just an issue of the secret not being set for an external PR, so I'm ok to ship this without the test passing (this PR doesn't touch the library code that gets tested anyway). |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the forevervm package to use platform.uname().machine for determining the system architecture, in order to improve accuracy in binary suffix selection.
- Import the platform module and extract uname machine information
- Update Windows architecture mapping from "x86_64" to "AMD64"
- Adjust binary file path and URL generation to use the new variables
Comments suppressed due to low confidence (1)
python/forevervm/forevervm/init.py:21
- Verify that platform.uname().machine consistently returns 'AMD64' on all Windows systems; inconsistency may cause the binary URL mapping to fail. If returns vary, consider implementing normalization for Windows architecture values.
("win32", "AMD64"): "win-x64.exe.gz",
paulgb
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #118.