Add stream result endpoint to JS SDK #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
javascript/sdk/src/index.ts
Outdated
| if (done) return | ||
|
|
||
| const lines = decoder | ||
| .decode(value) |
Contributor
There was a problem hiding this comment.
Consider handling partial JSON lines: use decoder.decode() with { stream: true } and accumulate unfinished lines across chunks to avoid parsing errors.
Suggested change
| .decode(value) | |
| .decode(value, { stream: true }) |
Contributor
Author
There was a problem hiding this comment.
Good bot, I didn't know about this and it ended up leading me to TextDecoderStream which is really what we want.
paulgb
approved these changes
Mar 10, 2025
jakelazaroff
force-pushed
the
jake/exec-result-stream
branch
from
3c36428 to
3c493f2
Compare
Contributor
Author
|
These tests should pass now that https://github.com/jamsocket/forevervm-platform/pull/242 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin!