Conversation
Rather than exposing two timeout parameters, why not just set the HTTP timeout based on the instruction timeout? I think that exposing both |
I agree but I do think they're distinct concerns — like, maybe you know your instruction might take up to 30 seconds to run, but you don't want to potentially wait up to 30 seconds to submit it. But maybe that's too niche to worry about right now and we should just combine them until someone actually wants to set them differently? |
82d06e5 to
0135142
Compare
0135142 to
2ae267d
Compare
2ae267d to
05c2f23
Compare
Adds timeout to Python SDK via the keyword argumenttimeout, which accepts either an int or an httpx Timeout object.The only method missing it isexec— it's a little weird there because we already havetimeout_secondswhich controls the timeout of the running Python instruction (I've renamed that toinstruction_timeout_secondsto better match) and also because we wrap two separate API requests with that one command. Open to suggestions on how to include it there too!Increases the timeout of
exec_resultandexec_result_asyncto 20 minutes, which is longer than users can set the instruction timeout.