expose timeout_seconds for exec{_async} #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
python/sdk/forevervm_sdk/repl.py
Outdated
|
|
||
| import httpx | ||
| from httpx_ws import WebSocketSession, connect_ws | ||
| from python.sdk.forevervm_sdk import DEFAULT_INSTRUCTION_TIMEOUT_SECONDS |
Contributor
There was a problem hiding this comment.
Importing DEFAULT_INSTRUCTION_TIMEOUT_SECONDS from init.py here creates a circular dependency (since init.py imports Repl from repl.py). Consider moving shared constants to a separate module to break the cycle.
paulgb
force-pushed
the
paul/dis-3214-expose-timeout_seconds-for-exec_async
branch
from
aa09546 to
d188b3d
Compare
paulgb
commented
Feb 18, 2025
python/sdk/forevervm_sdk/repl.py
Outdated
| class ReplExecResult: | ||
| _request_id = -1 | ||
| _instruction_id = -1 | ||
| _output = deque[StandardOutput]() |
Member
Author
There was a problem hiding this comment.
the changes here are related but came up during linting and minimal enough that I threw them into this PR
rolyatmax
approved these changes
Feb 18, 2025
paulgb
deleted the
paul/dis-3214-expose-timeout_seconds-for-exec_async
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.